Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Wait for events before rendering messages #4994

Merged
merged 11 commits into from
Nov 14, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented Nov 14, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions
I created a new hook to manage the rate at which the messages are received. If they are under the given threshold (e.g., 500 ms) then the state is loading. Otherwise, if they are above OR the time passed since the last message is > 500 ms, it is not loading


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:6abe70d-nikolaik   --name openhands-app-6abe70d   docker.all-hands.dev/all-hands-ai/openhands:6abe70d

@amanape amanape requested review from rbren and tofarr November 14, 2024 11:42
@amanape amanape self-assigned this Nov 14, 2024
@amanape amanape marked this pull request as ready for review November 14, 2024 17:46
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@amanape amanape merged commit 01cacf7 into main Nov 14, 2024
13 checks passed
@amanape amanape deleted the ALL-556/wait-for-events branch November 14, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants